docs(FR-2532): fix incorrect permission labels in share_vfolder documentation#6570
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nowgnuesLee
left a comment
There was a problem hiding this comment.
Review: PR #6570 — docs: fix incorrect permission labels in share_vfolder documentation
Summary
This PR correctly fixes the permission labels from "View"/"Edit" to "Read only"/"Read & Write" across all 4 languages, matching the actual UI labels defined in resources/i18n/{lang}.json. Additionally, the Japanese and Thai files are properly translated from previously untranslated English text — a significant quality improvement.
Verification
I checked the i18n source of truth for the permission labels:
| Language | ReadOnly key |
ReadWrite key |
Matches docs? |
|---|---|---|---|
| EN | Read only |
Read & Write |
Yes |
| KO | 읽기 전용 |
읽기 및 쓰기 |
Yes |
| JA | 読み取り専用 |
読み書き可能 |
Yes |
| TH | อ่านเท่านั้น |
อ่านและเขียน |
Yes |
Findings
All changes look correct. A few bonus fixes are appreciated:
- EN: typo fix
storge->storage, missing space after comma - EN: casing fix
Read Only->Read only(matching i18n key exactly) - JA/TH: Full translation of previously untranslated English paragraphs, including section headings ("Stop sharing a folder" etc.)
- JA: Consistent use of
フォルダinstead of mixedフォルダー(both are acceptable in Japanese, but consistency is good) - Missing newline at end of file fixed for ja/th
All terminology matches TERMINOLOGY.md (e.g., ストレージフォルダ in JA, โฟลเดอร์จัดเก็บ in TH). Cross-reference anchors remain in English as required. Structural parity across all 4 languages is maintained.
Recommendation
LGTM. Clean documentation fix with accurate translations.
86cc8fc to
43e5370
Compare
43e5370 to
ad15443
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the Backend.AI WebUI user manual across all 4 languages (en/ko/ja/th), aligning documentation with current UI labels and expanding/rewriting several user-facing pages (not only share_vfolder).
Changes:
- Update storage folder sharing documentation (permission labels, dialog field descriptions, and workflow text).
- Rewrite/expand core UX documentation pages (Start, Login, User Settings, Header/Top Bar, Dashboard) across en/ko/ja/th to reflect current UI behavior and options.
- Add/standardize additional sections such as Start-from-URL workflows, login modes (Session/API), SSO/OTP, and dashboard auto-refresh/layout customization.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/backend.ai-webui-docs/src/en/share_vfolder/share_vfolder.md | Refines sharing workflow text and permission label descriptions. |
| packages/backend.ai-webui-docs/src/ko/share_vfolder/share_vfolder.md | Korean equivalent updates for sharing workflow and permission labels. |
| packages/backend.ai-webui-docs/src/ja/share_vfolder/share_vfolder.md | Japanese equivalent updates for sharing workflow and permission labels. |
| packages/backend.ai-webui-docs/src/th/share_vfolder/share_vfolder.md | Thai equivalent updates for sharing workflow and permission labels. |
| packages/backend.ai-webui-docs/src/en/user_settings/user_settings.md | Rewrites General tab documentation; adds/updates settings descriptions. |
| packages/backend.ai-webui-docs/src/ko/user_settings/user_settings.md | Korean equivalent updates for User Settings page content and structure. |
| packages/backend.ai-webui-docs/src/ja/user_settings/user_settings.md | Japanese equivalent updates for User Settings page content and structure. |
| packages/backend.ai-webui-docs/src/th/user_settings/user_settings.md | Thai equivalent updates for User Settings page content and structure. |
| packages/backend.ai-webui-docs/src/en/start/start.md | Expands Start page guide (announcement banner, action cards, Start From URL flows). |
| packages/backend.ai-webui-docs/src/ko/start/start.md | Korean equivalent Start page expansion. |
| packages/backend.ai-webui-docs/src/ja/start/start.md | Japanese equivalent Start page expansion. |
| packages/backend.ai-webui-docs/src/th/start/start.md | Thai equivalent Start page expansion. |
| packages/backend.ai-webui-docs/src/en/login/login.md | Updates login/signup instructions; adds connection mode, SSO, OTP/TOTP sections. |
| packages/backend.ai-webui-docs/src/ko/login/login.md | Korean equivalent login/signup expansion. |
| packages/backend.ai-webui-docs/src/ja/login/login.md | Japanese equivalent login/signup expansion. |
| packages/backend.ai-webui-docs/src/th/login/login.md | Thai equivalent login/signup expansion. |
| packages/backend.ai-webui-docs/src/en/header/header.md | Adds login session timer + responsive layout; refines user menu descriptions. |
| packages/backend.ai-webui-docs/src/ko/header/header.md | Korean equivalent header/top bar expansion. |
| packages/backend.ai-webui-docs/src/ja/header/header.md | Japanese equivalent header/top bar expansion. |
| packages/backend.ai-webui-docs/src/th/header/header.md | Thai equivalent header/top bar expansion. |
| packages/backend.ai-webui-docs/src/en/dashboard/dashboard.md | Adds auto-refresh and layout customization sections; improves formatting. |
| packages/backend.ai-webui-docs/src/ko/dashboard/dashboard.md | Korean equivalent dashboard expansion. |
| packages/backend.ai-webui-docs/src/ja/dashboard/dashboard.md | Japanese equivalent dashboard expansion. |
| packages/backend.ai-webui-docs/src/th/dashboard/dashboard.md | Thai equivalent dashboard expansion. |
fadfba7 to
52e5cce
Compare
ed4a9bc to
2950281
Compare
2950281 to
28fc36b
Compare
846941e to
28fc36b
Compare
This reverts commit d3ca954. #6575 was merged with base=main because `gt track --parent main` on a locally untracked branch caused Graphite to record main as its parent. The subsequent `gt submit --publish --force` pushed this base change to GitHub, and the PR was then squash merged, collapsing 29 commits from 6 stacked PRs into a single commit on main: - #6570 docs(FR-2532): share_vfolder labels - #6571 docs(FR-2533): user_settings - #6572 docs(FR-2534): 2FA/TOTP/SSO login - #6573 docs(FR-2535): header session timer & menu - #6574 docs(FR-2536): Start From URL & announcement banner - #6575 docs(FR-2537): dashboard board customization & auto-refresh Reverting so each PR can be merged in its original stack order. After this revert merges: - #6575 will be reopened with its original base (#6574's branch) - #6625's base will be restored to #6611's branch - The other open PRs (#6570, #6571, #6572, #6573, #6574) retain their original bases and will be mergeable in stack order
Merge activity
|
…entation (#6570) Resolves #6676 (FR-2532) ## Summary - Fix incorrect permission label names in the share vfolder documentation across all 4 languages (EN/KO/JA/TH) - Correct label values from ambiguous descriptions to accurate UI labels: **Read-only**, **Read-write**, **Shared (Readable)**, **Shared (Writable)** - Fix inaccurate UI descriptions for the share dialog fields - Apply reviewer fixes for grammar and consistency ## Changes - `share_vfolder/share_vfolder.md` (en/ko/ja/th): corrected permission label names and share dialog field descriptions ## Test plan - [ ] Verify permission label names match the actual UI in all 4 languages - [ ] Verify share dialog field descriptions are accurate 🤖 Generated with [Claude Code](https://claude.com/claude-code)
28fc36b to
b106e27
Compare

Resolves #6676 (FR-2532)
Summary
Changes
share_vfolder/share_vfolder.md(en/ko/ja/th): corrected permission label names and share dialog field descriptionsTest plan
🤖 Generated with Claude Code